[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <bdfb596f-8658-3ca4-7b6f-bd749466097d@virtuozzo.com>
Date: Thu, 19 Jul 2018 19:27:48 +0300
From: Kirill Tkhai <ktkhai@...tuozzo.com>
To: David Laight <David.Laight@...LAB.COM>,
"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
"vdavydov.dev@...il.com" <vdavydov.dev@...il.com>,
"mhocko@...e.com" <mhocko@...e.com>,
"penguin-kernel@...ove.SAKURA.ne.jp"
<penguin-kernel@...ove.SAKURA.ne.jp>,
"shakeelb@...gle.com" <shakeelb@...gle.com>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: Cleanup in do_shrink_slab()
On 19.07.2018 19:21, David Laight wrote:
> From: Kirill Tkhai
>> Sent: 19 July 2018 17:05
>>
>> Group long variables together to minimize number of occupied lines
>> and place all definitions in back Christmas tree order.
>
> Grouping together unrelated variables doesn't really make the code
> any more readable.
> IMHO One variable per line is usually best.
>> Also, simplify expression around batch_size: use all power of C language!
>
> foo = bar ? : baz;
> Is not part of C, it is a gcc extension.
Then, use all power of GNU extensions.
Powered by blists - more mailing lists