linux-kernel - Re: [PATCH] security: export security_kernel_load_data to fix firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <41df8eb0-865f-3e53-eb13-cde642396cf7@infradead.org>
Date:   Thu, 19 Jul 2018 15:40:27 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Mimi Zohar <zohar@...ux.ibm.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-security-module <linux-security-module@...r.kernel.org>,
        James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        "Luis R. Rodriguez" <mcgrof@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] security: export security_kernel_load_data to fix
 firmware_loader build

On 07/19/2018 03:39 PM, Mimi Zohar wrote:
> Thanks, Randy.
> 
> On Thu, 2018-07-19 at 13:15 -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@...radead.org>
>>
>> Fix build error when CONFIG_FW_LOADER=m, CONFIG_FW_LOADER_USER_HELPER=y,
>> CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y, and CONFIG_SECURITY=y:
>>
>> ERROR: "security_kernel_load_data" [drivers/base/firmware_loader/firmware_class.ko] undefined!
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: James Morris <jmorris@...ei.org>
>> Cc: "Serge E. Hallyn" <serge@...lyn.com>
>> Cc: linux-security-module@...r.kernel.org
>> Cc: Luis R. Rodriguez <mcgrof@...nel.org>
>> ---
>>  security/security.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- linux-next-20180717.orig/security/security.c
>> +++ linux-next-20180717/security/security.c
>> @@ -1121,6 +1121,7 @@ int security_kernel_load_data(enum kerne
>>  		return ret;
>>  	return ima_load_data(id);
>>  }
>> +EXPORT_SYMBOL_GPL(security_kernel_load_data);
> 
> Arnd Bergmann already posted a similar patch, which is now staged in
> James' tree.
> 
> Mimi

Good.  Thanks.

-- 
~Randy