linux-kernel - Re: [PATCH] perf/x86/intel: Fix unwind errors from PEBS entries (mk-II)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201807200644.BeK4RHQU%fengguang.wu@intel.com>
Date:   Fri, 20 Jul 2018 06:45:09 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     kbuild-all@...org, Josh Poimboeuf <jpoimboe@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf/x86/intel: Fix unwind errors from PEBS entries
 (mk-II)

Hi Peter,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tip/perf/core]
[also build test WARNING on v4.18-rc5 next-20180719]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Peter-Zijlstra/perf-x86-intel-Fix-unwind-errors-from-PEBS-entries-mk-II/20180720-061741
config: i386-randconfig-x008-201828 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/perf_event.h:17:0,
                    from include/linux/trace_events.h:10,
                    from include/trace/trace_events.h:20,
                    from include/trace/define_trace.h:96,
                    from include/trace/events/mce.h:75,
                    from arch/x86/kernel/cpu/mcheck/mce.c:63:
>> include/uapi/linux/perf_event.h:147:39: warning: left shift count >= width of type [-Wshift-count-overflow]
     __PERF_SAMPLE_CALLCHAIN_EARLY  = 1UL << 63,
                                          ^~

vim +147 include/uapi/linux/perf_event.h

   118	
   119	/*
   120	 * Bits that can be set in attr.sample_type to request information
   121	 * in the overflow packets.
   122	 */
   123	enum perf_event_sample_format {
   124		PERF_SAMPLE_IP				= 1U << 0,
   125		PERF_SAMPLE_TID				= 1U << 1,
   126		PERF_SAMPLE_TIME			= 1U << 2,
   127		PERF_SAMPLE_ADDR			= 1U << 3,
   128		PERF_SAMPLE_READ			= 1U << 4,
   129		PERF_SAMPLE_CALLCHAIN			= 1U << 5,
   130		PERF_SAMPLE_ID				= 1U << 6,
   131		PERF_SAMPLE_CPU				= 1U << 7,
   132		PERF_SAMPLE_PERIOD			= 1U << 8,
   133		PERF_SAMPLE_STREAM_ID			= 1U << 9,
   134		PERF_SAMPLE_RAW				= 1U << 10,
   135		PERF_SAMPLE_BRANCH_STACK		= 1U << 11,
   136		PERF_SAMPLE_REGS_USER			= 1U << 12,
   137		PERF_SAMPLE_STACK_USER			= 1U << 13,
   138		PERF_SAMPLE_WEIGHT			= 1U << 14,
   139		PERF_SAMPLE_DATA_SRC			= 1U << 15,
   140		PERF_SAMPLE_IDENTIFIER			= 1U << 16,
   141		PERF_SAMPLE_TRANSACTION			= 1U << 17,
   142		PERF_SAMPLE_REGS_INTR			= 1U << 18,
   143		PERF_SAMPLE_PHYS_ADDR			= 1U << 19,
   144	
   145		PERF_SAMPLE_MAX = 1U << 20,		/* non-ABI */
   146	
 > 147		__PERF_SAMPLE_CALLCHAIN_EARLY		= 1UL << 63,
   148	};
   149	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (26680 bytes)