[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20180720092730.27104-1-tomasbortoli@gmail.com>
Date: Fri, 20 Jul 2018 11:27:30 +0200
From: Tomas Bortoli <tomasbortoli@...il.com>
To: ericvh@...il.com, rminnich@...dia.gov, lucho@...kov.net
Cc: jiangyiwen@...wei.com, davem@...emloft.net,
v9fs-developer@...ts.sourceforge.net, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, syzkaller@...glegroups.com,
Tomas Bortoli <tomasbortoli@...il.com>
Subject: [PATCH] [V9fs-developer] [PATCH] /net/9p/trans_fd.c: fix race-condition by flushing workqueue before the kfree()
The patch adds the flush in p9_mux_poll_stop() as it the function used by
p9_conn_destroy(), in turn called by p9_fd_close() to stop the async
polling associated with the data regarding the connection.
Signed-off-by: Tomas Bortoli <tomasbortoli@...il.com>
Reported-by: syzbot+39749ed7d9ef6dfb23f6@...kaller.appspotmail.com
---
As shown by Syzbot, it is possible to provoke a race between p9_fd_close()
and p9_poll_workfn() that is called to take care of the async read/write work
to do. To make sure p9_fd_close() frees "trans" when it is not used anymore,
it has to explicitly flush p9_poll_work before the kfree().
net/9p/trans_fd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c
index bf459ee0feab..a64b01c56e30 100644
--- a/net/9p/trans_fd.c
+++ b/net/9p/trans_fd.c
@@ -185,6 +185,8 @@ static void p9_mux_poll_stop(struct p9_conn *m)
spin_lock_irqsave(&p9_poll_lock, flags);
list_del_init(&m->poll_pending_link);
spin_unlock_irqrestore(&p9_poll_lock, flags);
+
+ flush_work(&p9_poll_work);
}
/**
--
2.11.0
Powered by blists - more mailing lists