linux-kernel - Re: [PATCH 3/5] dmaengine: mv_xor_v2: convert callback to helper function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180720092921.GR3219@vkoul-mobl>
Date:   Fri, 20 Jul 2018 14:59:21 +0530
From:   Vinod <vkoul@...nel.org>
To:     hannah@...vell.com
Cc:     dan.j.williams@...el.com, dmaengine@...r.kernel.org,
        thomas.petazzoni@...tlin.com, linux-kernel@...r.kernel.org,
        nadavh@...vell.com, omrii@...vell.com, oferh@...vell.com,
        gregory.clement@...tlin.com
Subject: Re: [PATCH 3/5] dmaengine: mv_xor_v2: convert callback to helper
 function

On 17-07-18, 13:30, hannah@...vell.com wrote:
> From: Hanna Hawa <hannah@...vell.com>
> 
> This is in preperation of moving to a callback that provides results to the

typo preperation

> callback for the transaction. The conversion will maintain current behavior
> and the driver must convert to new callback mechanism at a later time in
> order to receive results.
> 
> Signed-off-by: Hanna Hawa <hannah@...vell.com>
> ---
>  drivers/dma/mv_xor_v2.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c
> index e718498..14e2a7a 100644
> --- a/drivers/dma/mv_xor_v2.c
> +++ b/drivers/dma/mv_xor_v2.c
> @@ -589,9 +589,8 @@ static void mv_xor_v2_tasklet(unsigned long data)
>  			 */
>  			dma_cookie_complete(&next_pending_sw_desc->async_tx);
>  
> -			if (next_pending_sw_desc->async_tx.callback)
> -				next_pending_sw_desc->async_tx.callback(
> -				next_pending_sw_desc->async_tx.callback_param);
> +			dmaengine_desc_get_callback_invoke(
> +					&next_pending_sw_desc->async_tx, NULL);
>  
>  			dma_descriptor_unmap(&next_pending_sw_desc->async_tx);
>  		}

-- 
~Vinod