linux-kernel - Re: [PATCH 05/12] dmar: Use for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180720125059.44d5werxu6w24vzk@suse.de>
Date:   Fri, 20 Jul 2018 14:50:59 +0200
From:   Joerg Roedel <jroedel@...e.de>
To:     Daniel Vetter <daniel.vetter@...ll.ch>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        Intel Graphics Development <intel-gfx@...ts.freedesktop.org>,
        Daniel Vetter <daniel.vetter@...el.com>
Subject: Re: [PATCH 05/12] dmar: Use for_each_If

On Mon, Jul 09, 2018 at 10:36:43AM +0200, Daniel Vetter wrote:
>  #define for_each_active_drhd_unit(drhd)					\
>  	list_for_each_entry_rcu(drhd, &dmar_drhd_units, list)		\
> -		if (drhd->ignored) {} else
> +		for_each_if (!drhd->ignored)

Hmm, in my tree the macro comes from

	include/drm/drmP.h:#define for_each_if(condition) if (!(condition)) {} else

Please re-submit when the macro is in a generic header upstream.


	Joerg