linux-kernel - Re: [PATCH] staging: dgnc: dgnc_tty.c: Avoid '(' at the end of line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180722171620.GA20134@nishad>
Date:   Sun, 22 Jul 2018 22:46:24 +0530
From:   Nishad Kamdar <nishadkamdar@...il.com>
To:     Joe Perches <joe@...ches.com>,
        Lidza Louina <lidza.louina@...il.com>,
        Mark Hounschell <markh@...pro.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: dgnc: dgnc_tty.c: Avoid '(' at the end of line

On Sun, Jul 22, 2018 at 12:50:25AM -0700, Joe Perches wrote:
> On Sun, 2018-07-22 at 09:39 +0530, Nishad Kamdar wrote:
> > Bring the first argument to the previous line and
> > align the other lines to match open parenthesis.
> []
> > diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> []
> > @@ -883,10 +883,9 @@ static int dgnc_tty_open(struct tty_struct *tty, struct file *file)
> >  	 * touched safely, the close routine will signal the
> >  	 * ch_flags_wait to wake us back up.
> >  	 */
> > -	rc = wait_event_interruptible(
> > -				ch->ch_flags_wait,
> > -				(((ch->ch_tun.un_flags |
> > -				ch->ch_pun.un_flags) & UN_CLOSING) == 0));
> > +	rc = wait_event_interruptible(ch->ch_flags_wait,
> > +				      (((ch->ch_tun.un_flags |
> > +				      ch->ch_pun.un_flags) & UN_CLOSING) == 0));
> 
> 
> This would be better without the superfluous () and perhaps use !
> 
> 	rc = wait_event_interruptible(ch->ch_flags_wait,
> 				      !((ch->ch_tun.un_flags |
> 					 ch->ch_pun.un_flags) & UN_CLOSING));
> 
> 

Ok, I will revise the patch.
Thanks for the review.

regards,
nishad kamdar