[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180723133200.GA1167@kroah.com>
Date: Mon, 23 Jul 2018 15:32:00 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: dev-harsh1998 <harshitjain6751@...il.com>
Cc: trivial@...nel.org, Dmitry Torokhov <dmitry.torokhov@...il.com>,
Simon Budig <simon.budig@...nelconcepts.de>,
Andi Shyti <andi@...zian.org>,
Luca Ceresoli <luca@...aceresoli.net>,
Joe Perches <joe@...ches.com>,
Guenter Roeck <linux@...ck-us.net>,
linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/11] touchscreen: elants: Use octal permissions
On Mon, Jul 23, 2018 at 06:49:20PM +0530, dev-harsh1998 wrote:
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
> +static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL);
>
> WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'.
> +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, write_update_fw)
>
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
> + .dattr = __ATTR(_field, S_IRUGO, \
>
> Signed-off-by: Harshit Jain <harshitjain6751@...il.com>
This name doesn't match up with the From: line above :(
Please fix up and try again.
thanks,
greg k-h
Powered by blists - more mailing lists