linux-kernel - Re: [PATCH] perf/x86/intel: Fix unwind errors from PEBS entries (mk-II)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180723141427.GA2458@hirez.programming.kicks-ass.net>
Date:   Mon, 23 Jul 2018 16:14:27 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf/x86/intel: Fix unwind errors from PEBS entries
 (mk-II)

On Mon, Jul 23, 2018 at 08:30:06AM -0500, Josh Poimboeuf wrote:
> On Thu, Jul 19, 2018 at 11:19:54PM +0200, Peter Zijlstra wrote:
> > --- a/include/uapi/linux/perf_event.h
> > +++ b/include/uapi/linux/perf_event.h
> > @@ -143,6 +143,8 @@ enum perf_event_sample_format {
> >  	PERF_SAMPLE_PHYS_ADDR			= 1U << 19,
> >  
> >  	PERF_SAMPLE_MAX = 1U << 20,		/* non-ABI */
> > +
> > +	__PERF_SAMPLE_CALLCHAIN_EARLY		= 1UL << 63,
> 
> Given the kbuild test robot errors for building on 32-bit, looks like
> the 63 needs to be changed to 31 so it fits in an int?

I made it 1ULL << 63. The actual field (perf_event_attr::sample_type is
u64).