linux-kernel - Re: WARNING in port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hsh49xfkn.wl-tiwai@suse.de>
Date:   Tue, 24 Jul 2018 09:23:20 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     DaeRyong Jeong <threeearcat@...il.com>
Cc:     Colin King <colin.king@...onical.com>, perex@...ex.cz,
        alsa-devel@...a-project.org, Kyungtae Kim <kt0755@...il.com>,
        Byoungyoung Lee <lifeasageek@...il.com>,
        syzkaller@...glegroups.com, bammanag@...due.edu,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: WARNING in port_delete

On Tue, 24 Jul 2018 09:14:14 +0200,
DaeRyong Jeong wrote:
> 
> I agree with that having a C reproducer would be much better.
> Now I'm working on it.
> I will immediately let you know once I get the C reproducer.

That's great, thanks!


Takashi

> 
> 
> Thank you.
> 
> Best regards,
> DaeRyong Jeong
> On 24 Jul 2018, 4:00 PM +0900, Takashi Iwai <tiwai@...e.de>, wrote:
> > On Tue, 24 Jul 2018 05:59:56 +0200,
> > DaeRyong Jeong wrote:
> > >
> > > I just realized that the crash has been spotted by Syzkaller a few days before.
> > > (https://syzkaller.appspot.com/bug?id=3490860a465e6b39227c6906f0ef2d40ad4d5bb1)
> > >
> > > I'm CC'ing Syzkaller's mailing list.
> >
> > It's very likely a false-positive sanity check, and if so, nothing
> > serious at all. We may simply remove two snd_BUG_ON() lines.
> >
> > But I'd love to have a C reproducer to confirm my understanding is
> > correct...
> >
> >
> > thanks,
> >
> > Takashi
> >
> > ---
> > --- a/sound/core/seq/seq_ports.c
> > +++ b/sound/core/seq/seq_ports.c
> > @@ -272,9 +272,6 @@ static int port_delete(struct snd_seq_client *client,
> > if (port->private_free)
> > port->private_free(port->private_data);
> >
> > - snd_BUG_ON(port->c_src.count != 0);
> > - snd_BUG_ON(port->c_dest.count != 0);
> > -
> > kfree(port);
> > return 0;
> > }
> [2  <text/html; utf-8 (quoted-printable)>]
>