linux-kernel - Re: Linux 4.18-rc6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180724092403.332125ff@mschwideX1>
Date:   Tue, 24 Jul 2018 09:24:03 +0200
From:   Martin Schwidefsky <schwidefsky@...ibm.com>
To:     Christian Borntraeger <borntraeger@...ibm.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Guenter Roeck <linux@...ck-us.net>,
        David Miller <davem@...emloft.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 4.18-rc6

On Tue, 24 Jul 2018 09:15:58 +0200
Christian Borntraeger <borntraeger@...ibm.com> wrote:

> On 07/24/2018 08:18 AM, Martin Schwidefsky wrote:
> > On Mon, 23 Jul 2018 16:17:22 -0700
> > Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> >   
> >> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck <linux@...ck-us.net> wrote:  
> >>>    
> >>>>
> >>>> Martin - can we just remove the
> >>>>
> >>>>          select HAVE_GCC_PLUGINS
> >>>>
> >>>> from the s390 Kconfig file (or perhaps add "if BROKEN" or something to
> >>>> disable it).
> >>>>
> >>>> Because if it's not getting fixed, it shouldn't be exposed.
> >>>>    
> >>> The problem only affects 4.18 - the code has been rearranged in -next.
> >>> Only, in my builders, I can't disable a flag for individual releases,
> >>> so I just disabled it completely for s390.    
> >>
> >> Well, I'm not going to release a 4.18 with a known problem, so in 4.18
> >> this *will* be disabled if it's not fixed.
> >>
> >> The fact that it might be fixed in linux-next is entirely immaterial
> >> to the release of 4.18.  
> > 
> > Ok, if gcc with the plugins and an allmodconfig is considered to be
> > important enough to warrant a fix, it can be pulled from here:
> > 
> > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus
> > 
> > Martin Schwidefsky (1):
> >       s390: disable gcc plugins
> > 
> > Once that is in I will create another patch to undo this one and place
> > it after the early boot rework.  
> 
> On the list a different fix was proposed about 2 weeks ago,
> 
> something like
> 
> CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
> 
> and I prefer that. Because your patch disables all gcc plugins.

This change would cause trouble with patch dependencies as als.c is moved
to a different directory. I would prefer to disable all gcc plugins for
4.18.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.