linux-kernel - Re: [PATCH/RFT 2/6] i2c: imx: use open drain for recovery GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180724072759.iirtq7qhydn4ep34@ninjato>
Date:   Tue, 24 Jul 2018 09:28:00 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Lucas Stach <l.stach@...gutronix.de>
Cc:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-i2c@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH/RFT 2/6] i2c: imx: use open drain for recovery GPIO

Hi Lucas,

> I don't think this matters on any of the i.MX platforms, as the GPIO
> pin configuration (including open-drain) is only taken from the DT
> pinctrl, with the GPIO driver not being able to change any of those. On
>  the flipside this results in a near zero probability of regressions.
> ;)

I see. Thanks for the heads up.

> As this is obviously right even if it doesn't have any effect on
> current software:
> 
> Reviewed-by: Lucas Stach <l.stach@...gutronix.de>

Thanks. Yeah, let's fix it. It might serve as an example for other
people.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)