[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK8P3a1e-HHm9+sYYmsgOHtqLK_GD_uMxuKg9dMo_xEfHAHP5g@mail.gmail.com>
Date: Tue, 24 Jul 2018 11:23:14 +0200
From: Arnd Bergmann <arnd@...db.de>
To: Finn Thain <fthain@...egraphics.com.au>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>,
linux-m68k <linux-m68k@...ts.linux-m68k.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] m68k/mac: Rework patch "use time64_t in RTC handling"
On Tue, Jul 24, 2018 at 9:07 AM, Finn Thain <fthain@...egraphics.com.au> wrote:
> This addresses the issues arising from commit 324caa29cd04
> ("m68k: mac: use time64_t in RTC handling").
>
> Adopt __u32 for the union in via_read_time(), consistent with changes
> to via_write_time().
>
> Use low_32_bits() in via_write_time(), consistent with changes to
> pmu_write_time() and cuda_write_time().
>
> Have via_read_time() return a time64_t, consistent with changes to
> pmu_read_time and cuda_read_time().
>
> Drop the pointless wraparound conditional in via_read_time().
>
> Cc: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
Reviewed-by: Arnd Bergmann <arnd@...db.de>
Thanks for fixing it up!
Powered by blists - more mailing lists