linux-kernel - Re: [PATCH] m68k/mac: Rework patch "use time64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdWaJEEvt_-g7Lp8Wwc=UbT6tSYewGK0YWgDhC=GVX=LyA@mail.gmail.com>
Date:   Sun, 29 Jul 2018 11:00:15 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Finn Thain <fthain@...egraphics.com.au>,
        Arnd Bergmann <arnd@...db.de>
Cc:     linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] m68k/mac: Rework patch "use time64_t in RTC handling"

Hi Finn, Arnd,

On Tue, Jul 24, 2018 at 9:07 AM Finn Thain <fthain@...egraphics.com.au> wrote:
> This addresses the issues arising from commit 324caa29cd04
> ("m68k: mac: use time64_t in RTC handling").
>
> Adopt __u32 for the union in via_read_time(), consistent with changes
> to via_write_time().
>
> Use low_32_bits() in via_write_time(), consistent with changes to

lower_32_bits()

> pmu_write_time() and cuda_write_time().
>
> Have via_read_time() return a time64_t, consistent with changes to
> pmu_read_time and cuda_read_time().

pmu_read_time()

> Drop the pointless wraparound conditional in via_read_time().
>
> Cc: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>

Thanks!

Applied to master with the above fixed.
Folded into the original commit on for-v4.19, with:

    [fthain: Adopt __u32 for the union in via_read_time(), consistent with
             changes to via_write_time()]
    [fthain: Use lower_32_bits() in via_write_time(), consistent with changes
             to pmu_write_time() and cuda_write_time()]
    [fthain: Have via_read_time() return a time64_t, consistent with changes
             to pmu_read_time() and cuda_read_time()]
    [fthain: Drop the pointless wraparound conditional in via_read_time()]
    Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
    Reviewed-by: Arnd Bergmann <arnd@...db.de>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds