linux-kernel - Re: [PATCH] EDAC, sb_edac: Fix out of bound in PCI multi segment env

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3f2847a-1b31-b291-ba3c-5e2a7c2478c5@gmail.com>
Date:   Tue, 24 Jul 2018 14:41:12 -0400
From:   Masayoshi Mizuma <msys.mizuma@...il.com>
To:     tony.luck@...el.com
Cc:     mchehab@...nel.org, bp@...en8.de, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org, m.mizuma@...fujitsu.com
Subject: Re: [PATCH] EDAC, sb_edac: Fix out of bound in PCI multi segment env

Hi Tony,

Thank you for your review!

On 07/24/2018 01:01 PM, Tony Luck wrote:
> On Thu, Jul 19, 2018 at 7:07 AM, Masayoshi Mizuma <msys.mizuma@...il.com> wrote:
>> From: Masayoshi Mizuma <m.mizuma@...fujitsu.com>
>>
>> KASAN reported the following slab-out-of-bounds when sb_edac
>> module was loaded on Broadwell machine which has two PCI segments.
> 
> Although you found this with KASAN as an out of bounds array reference,
> the real problem is that the sb_edac.c driver didn't know about systems
> with segmented PCI busses.
> 
> So the Subject: for the e-mail (and thus the commit message) should
> be:
> 
> [PATCH] EDAC, sb_edac: Add support for systems with segmented PCI busses

You are right. I will modify the subject and commit message, and resend it.

> 
> Otherwise this looks fine.
> 
> Reviewed-by: Tony Luck <tony.luck@...el.com>

Thanks!
Masa

> 
> -Tony
>