linux-kernel - Re: [PATCH] EDAC, sb_edac: Fix out of bound in PCI multi segment env

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+8MBbJSox7YsfoL=90yiLp8_oHFEjkN3-nk95rGbUmk58R0Gw@mail.gmail.com>
Date:   Tue, 24 Jul 2018 10:01:57 -0700
From:   Tony Luck <tony.luck@...el.com>
To:     Masayoshi Mizuma <msys.mizuma@...il.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Borislav Petkov <bp@...en8.de>,
        Linux Edac Mailing List <linux-edac@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Masayoshi Mizuma <m.mizuma@...fujitsu.com>
Subject: Re: [PATCH] EDAC, sb_edac: Fix out of bound in PCI multi segment env

On Thu, Jul 19, 2018 at 7:07 AM, Masayoshi Mizuma <msys.mizuma@...il.com> wrote:
> From: Masayoshi Mizuma <m.mizuma@...fujitsu.com>
>
> KASAN reported the following slab-out-of-bounds when sb_edac
> module was loaded on Broadwell machine which has two PCI segments.

Although you found this with KASAN as an out of bounds array reference,
the real problem is that the sb_edac.c driver didn't know about systems
with segmented PCI busses.

So the Subject: for the e-mail (and thus the commit message) should
be:

[PATCH] EDAC, sb_edac: Add support for systems with segmented PCI busses

Otherwise this looks fine.

Reviewed-by: Tony Luck <tony.luck@...el.com>

-Tony