linux-kernel - Re: [PATCH v4 04/35] mtd: rawnand: denali: convert to nand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180725144717.604d3197@xps13>
Date:   Wed, 25 Jul 2018 14:47:17 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Boris Brezillon <boris.brezillon@...tlin.com>
Cc:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Mans Rullgard <mans@...sr.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Stefan Agner <stefan@...er.ch>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        Kamal Dasu <kdasu.kdev@...il.com>,
        Josh Wu <rainyfeeling@...look.com>,
        Marc Gonzalez <marc.w.gonzalez@...e.fr>,
        Marek Vasut <marek.vasut@...il.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Broadcom Kernel Feedback List 
        <bcm-kernel-feedback-list@...adcom.com>,
        Sylvain Lemieux <slemieux.tyco@...il.com>,
        Wenyou Yang <wenyou.yang@...rochip.com>,
        Tudor Ambarus <Tudor.Ambarus@...rochip.com>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Harvey Hunt <harveyhuntnexus@...il.com>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Han Xu <han.xu@....com>, Xiaolei Li <xiaolei.li@...iatek.com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Richard Weinberger <richard@....at>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH v4 04/35] mtd: rawnand: denali: convert to nand_scan()

Hi Boris,

Boris Brezillon <boris.brezillon@...tlin.com> wrote on Wed, 25 Jul 2018
11:51:16 +0200:

> On Wed, 25 Jul 2018 18:42:44 +0900
> Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:
> 
> > 
> > You need to remove kfree(denali->buf)
> > from denali_remove(), right?  
> 
> Absolutely.
> 
> > 
> > void denali_remove(struct denali_nand_info *denali)
> > {
> >         struct mtd_info *mtd = nand_to_mtd(&denali->nand);
> > 
> >         nand_release(mtd);
> >         kfree(denali->buf);       <---- REMOVE !!
> >         denali_disable_irq(denali);
> > }
> > 
> > 
> > Otherwise, denali_remove() will free denali->buf twice
> > because kfree(denali->buf) is called from denali_detach_chip().  
> 

Absolutely, thanks for reviewing!

I'll apply with this changed.

Miquèl