linux-kernel - Re: [PATCH] kprobes: fix trace_probe flags in enable_trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180725100541.36f27954@gandalf.local.home>
Date:   Wed, 25 Jul 2018 10:05:41 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     Artem Savkov <asavkov@...hat.com>, Ingo Molnar <mingo@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kprobes: fix trace_probe flags in enable_trace_kprobe

On Wed, 25 Jul 2018 08:56:32 -0500
Josh Poimboeuf <jpoimboe@...hat.com> wrote:

> On Wed, Jul 25, 2018 at 12:28:26PM +0200, Artem Savkov wrote:
> > If enable_trace_kprobe fails to enable the probe in enable_k(ret)probe
> > it returns an error, but does not unset the tp flags it set previosly.  
> 
> "previously"

I tentatively added this to my queue. I updated the subject as:

 tracing/kprobes: Fix trace_probe flags on enable_trace_kprobe() failure

But yeah, that needs to be fixed.

> 
> > @@ -424,6 +423,16 @@ enable_trace_kprobe(struct trace_kprobe *tk, struct trace_event_file *file)
> >  		else
> >  			ret = enable_kprobe(&tk->rp.kp);
> >  	}
> > +
> > +	if (ret) {
> > +		if (file) {
> > +			list_del(&link->list);  
> 
> Should this be list_del_rcu(), since it was added to the list with
> list_add_tail_rcu()?
> 

Good catch. Yes, that should be list_del_rcu().

Artem,

Can you send a v2 with the changes.

Thanks,

-- Steve