linux-kernel - RE: [PATCH 4/8] usb: dwc3: implement stream transfer timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Jul 2018 15:14:55 +0000
From:   Anurag Kumar Vulisha <anuragku@...inx.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "v.anuragkumar@...il.com" <v.anuragkumar@...il.com>,
        USB <linux-usb@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 4/8] usb: dwc3: implement stream transfer timeout

Hi Andy,

Thanks for your review comments, please find my comments inline 

>-----Original Message-----
>From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
>Sent: Wednesday, July 25, 2018 8:36 PM
>To: Anurag Kumar Vulisha <anuragku@...inx.com>
>Cc: Felipe Balbi <balbi@...nel.org>; Greg Kroah-Hartman
><gregkh@...uxfoundation.org>; v.anuragkumar@...il.com; USB <linux-
>usb@...r.kernel.org>; Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
>Subject: Re: [PATCH 4/8] usb: dwc3: implement stream transfer timeout
>
>On Wed, Jul 25, 2018 at 2:51 PM, Anurag Kumar Vulisha
><anurag.kumar.vulisha@...inx.com> wrote:
>> According to dwc3 databook when streams are used, it may be possible
>> for the host and device become out of sync, where device may wait for
>> host to issue prime transcation and host may wait for device to issue
>> erdy. To avoid such deadlock, timeout needs to be implemented. After
>> timeout occurs, device will first stop transfer and restart the
>> transfer again. This patch does the same.
>
>> +/*
>> + * Timeout value in msecs used by stream_timeout_timer when streams
>> +are enabled  */
>> +#define STREAM_TIMEOUT         50
>
>Perhaps, STREAM_TIMEOUT_MS 50
>
>Dunno about this driver, but it's a usual practice to help reader with understanding
>code on the first glance.
>

Since I have mentioned "msecs" in comment above describing the STREAM_TIMEOUT,
thought it would suffice. But if you feel I should change it, I  will fix it in v2

Thanks,
Anurag Kumar Vulisha
 
>--
>With Best Regards,
>Andy Shevchenko