linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: fix 32-bit format string warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08f5d7dd-a271-4cef-4cf3-950c4c251c91@kernel.org>
Date:   Wed, 25 Jul 2018 23:21:02 +0800
From:   Chao Yu <chao@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>, Jaegeuk Kim <jaegeuk@...nel.org>,
        Chao Yu <yuchao0@...wei.com>
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, Eric Biggers <ebiggers@...gle.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix 32-bit format string warning

On 2018/7/24 17:34, Arnd Bergmann wrote:
> On 32-bit targets, size_t is often 'unsigned int', so printing it as %lu
> causes a warning:
> 
> fs/f2fs/inode.c: In function 'sanity_check_inode':
> fs/f2fs/inode.c:247:4: error: format '%lu' expects argument of type 'long unsigned int', but argument 7 has type 'unsigned int' [-Werror=format=]
> 
> The correct format string is %zu.
> 
> Fixes: ba3a252d3367 ("f2fs: fix to do sanity check with i_extra_isize")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

I noticed the issue, thank you for fixing it, but original buggy patch has not
been upstreamed yet, how about merging this fix into origial patch, if you don't
mind?

Thanks,

> ---
>  fs/f2fs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> index 3fe63b0c7325..4fd339fd3ff2 100644
> --- a/fs/f2fs/inode.c
> +++ b/fs/f2fs/inode.c
> @@ -245,7 +245,7 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page)
>  		set_sbi_flag(sbi, SBI_NEED_FSCK);
>  		f2fs_msg(sbi->sb, KERN_WARNING,
>  			"%s: inode (ino=%lx) has corrupted i_extra_isize: %d, "
> -			"max: %lu",
> +			"max: %zu",
>  			__func__, inode->i_ino, fi->i_extra_isize,
>  			F2FS_TOTAL_EXTRA_ATTR_SIZE);
>  		return false;
>