linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: fix 32-bit format string warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Jul 2018 21:37:24 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Chao Yu <chao@...nel.org>
Cc:     Jaegeuk Kim <jaegeuk@...nel.org>, Chao Yu <yuchao0@...wei.com>,
        "Linux F2FS DEV, Mailing List" 
        <linux-f2fs-devel@...ts.sourceforge.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Eric Biggers <ebiggers@...gle.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix 32-bit format string warning

On Wed, Jul 25, 2018 at 5:21 PM, Chao Yu <chao@...nel.org> wrote:
> On 2018/7/24 17:34, Arnd Bergmann wrote:
>> On 32-bit targets, size_t is often 'unsigned int', so printing it as %lu
>> causes a warning:
>>
>> fs/f2fs/inode.c: In function 'sanity_check_inode':
>> fs/f2fs/inode.c:247:4: error: format '%lu' expects argument of type 'long unsigned int', but argument 7 has type 'unsigned int' [-Werror=format=]
>>
>> The correct format string is %zu.
>>
>> Fixes: ba3a252d3367 ("f2fs: fix to do sanity check with i_extra_isize")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> I noticed the issue, thank you for fixing it, but original buggy patch has not
> been upstreamed yet, how about merging this fix into origial patch, if you don't
> mind?

Yes, please do that.

      Arnd