linux-kernel - Re: [PATCH 13/15] ARM: tegra: apalis-tk1: fix pcie switch vendor compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Jul 2018 09:34:49 +0200
From:   Stefan Agner <stefan@...er.ch>
To:     Marcel Ziswiler <marcel@...wiler.com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Mark Rutland <mark.rutland@....com>,
        linux-tegra-owner@...r.kernel.org
Subject: Re: [PATCH 13/15] ARM: tegra: apalis-tk1: fix pcie switch vendor
 compatible

On 24.07.2018 12:43, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> 
> PLX got bought by Broadcom therefore fix device tree compatible string
> vendor which silences the following checkpatch.pl warning:
> 
> WARNING: DT compatible string vendor "plx" appears un-documented
>  -- check ./Documentation/devicetree/bindings/vendor-prefixes.txt

This seems to be not the only instance, there are other places where plx
prefix is used. There are 8 instances in total, 4 ARM (in fact all
Toradex device trees) and 4 PowerPC.

One device is already documented in
Documentation/devicetree/bindings/trivial-devices.txt:
plx,pex8648               48-Lane, 12-Port PCI Express Gen 2 (5.0 GT/s)
Switch

I suggest to just add plx as a valid vendor prefix by adding plx to
Documentation/devicetree/bindings/vendor-prefixes.txt:
plx	Broadcom Corporation (formerly PLX Technology)

--
Stefan

> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> 
> ---
> 
>  arch/arm/boot/dts/tegra124-apalis-eval.dts      | 2 +-
>  arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/tegra124-apalis-eval.dts
> b/arch/arm/boot/dts/tegra124-apalis-eval.dts
> index d9805fc97f5e..84ab7dc9febb 100644
> --- a/arch/arm/boot/dts/tegra124-apalis-eval.dts
> +++ b/arch/arm/boot/dts/tegra124-apalis-eval.dts
> @@ -109,7 +109,7 @@
>  		clock-frequency = <400000>;
>  
>  		pcie-switch@58 {
> -			compatible = "plx,pex8605";
> +			compatible = "brcm,pex8605";
>  			reg = <0x58>;
>  		};
>  
> diff --git a/arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts
> b/arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts
> index 89783fe76f65..5319f88d3cab 100644
> --- a/arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts
> +++ b/arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts
> @@ -74,7 +74,7 @@
>  		clock-frequency = <400000>;
>  
>  		pcie-switch@58 {
> -			compatible = "plx,pex8605";
> +			compatible = "brcm,pex8605";
>  			reg = <0x58>;
>  		};