linux-kernel - Re: [PATCH 13/26] ARM: tegra: colibri_t30: use proper irq-gpio for stmpe811

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <844bac7c4e00a014f5e5b857e38a47bf@agner.ch>
Date:   Thu, 26 Jul 2018 10:07:09 +0200
From:   Stefan Agner <stefan@...er.ch>
To:     Marcel Ziswiler <marcel@...wiler.com>
Cc:     devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-tegra-owner@...r.kernel.org
Subject: Re: [PATCH 13/26] ARM: tegra: colibri_t30: use proper irq-gpio for
 stmpe811

On 23.07.2018 14:36, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> 
> Use proper irq-gpio for stmpe811 touch controller.

I don't think this change is necessary, interrupts/interrupt-parent
specification seems to be supported by the driver as well.

--
Stefan

> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> 
> ---
> 
>  arch/arm/boot/dts/tegra30-colibri.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi
> b/arch/arm/boot/dts/tegra30-colibri.dtsi
> index c80b9bf44752..ace72a53186a 100644
> --- a/arch/arm/boot/dts/tegra30-colibri.dtsi
> +++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
> @@ -836,8 +836,7 @@
>  		stmpe811@41 {
>  			compatible = "st,stmpe811";
>  			reg = <0x41>;
> -			interrupts = <TEGRA_GPIO(V, 0) IRQ_TYPE_LEVEL_LOW>;
> -			interrupt-parent = <&gpio>;
> +			irq-gpio = <&gpio TEGRA_GPIO(V, 0) IRQ_TYPE_LEVEL_LOW>;
>  			interrupt-controller;
>  			id = <0>;
>  			blocks = <0x5>;