linux-kernel - Re: include architecture Kconfig files from top-level Kconfig v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180726172143.GA9836@lst.de>
Date:   Thu, 26 Jul 2018 19:21:43 +0200
From:   Christoph Hellwig <hch@....de>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Christoph Hellwig <hch@....de>,
        Randy Dunlap <rdunlap@...radead.org>,
        Richard Weinberger <richard@....at>,
        Ley Foon Tan <lftan@...era.com>,
        Michal Simek <monstr@...str.eu>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        linux-um@...ts.infradead.org, linux-arch@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: include architecture Kconfig files from top-level Kconfig v3

On Wed, Jul 25, 2018 at 01:30:24PM +0900, Masahiro Yamada wrote:
> Could you check the difference of CONFIG_PREEMPT_COUNT, please?
> 
> 
> For alpha, hexagon, um,
> CONFIG_PREEMPT_COUNT was previously never enabled
> because kernel/Kconfig.preempt was not included.
> 
> Now, CONFIG_PREEMPT_COUNT can be enabled
> if it is select'ed by someone.
> 
> I guess this change will be OK, but
> I'd like you and Randy to double-check it just in case.

It might be fine, but with this little fix folded in we should be
safer:

diff --git a/kernel/Kconfig.preempt b/kernel/Kconfig.preempt
index cd1655122ec0..1321a4a7a677 100644
--- a/kernel/Kconfig.preempt
+++ b/kernel/Kconfig.preempt
@@ -57,4 +57,5 @@ config PREEMPT
 endchoice
 
 config PREEMPT_COUNT
-       bool
\ No newline at end of file
+	depends on !ARCH_NO_PREEMPT
+	bool