linux-kernel - Re: [REPOST PATCH 3/4] usb: dwc2: Turn on uframe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <410670D7E743164D87FA6160E7907A56013A5CBE48@am04wembxa.internal.synopsys.com>
Date:   Fri, 27 Jul 2018 11:11:00 +0000
From:   Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>
To:     Douglas Anderson <dianders@...omium.org>,
        "balbi@...nel.org" <balbi@...nel.org>,
        "Minas.Harutyunyan@...opsys.com" <Minas.Harutyunyan@...opsys.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "stefan.wahren@...e.com" <stefan.wahren@...e.com>,
        "grigor.tovmasyan@...opsys.com" <grigor.tovmasyan@...opsys.com>,
        "Bruno Herrera" <bruherrera@...il.com>,
        Zhangfei Gao <zhangfei.gao@...aro.org>,
        "john.stultz@...aro.org" <john.stultz@...aro.org>,
        Stephen Warren <swarren@...dotorg.org>,
        Jerome Brunet <jbrunet@...libre.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [REPOST PATCH 3/4] usb: dwc2: Turn on uframe_sched on "amlogic"
 platforms

On 7/27/2018 12:08 AM, Douglas Anderson wrote:
> There's no reason to have the uframe scheduler off on dwc2.  Running
> with uframe_sched = False is equivalent to saying "I don't want to run
> the correct code, I want to run the old and incorrect code".
> 
> The uframe scheduler has been off on Amlogic since commit f94310ac076e
> ("usb: dwc2: add support for Meson8b and GXBB SoCs").  While this was
> after most of the recent improvements, notably the commit 9f9f09b048f5
> ("usb: dwc2: host: Totally redo the microframe scheduler"), presumably
> the parameters were copied from another platform and the uframe
> scheduler wasn't tried.
> 
> Presumably if everyone is good w/ the uframe_sched turned back on we
> can kill all the old and crufty non-uframe sched code.
> 
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

Reviewed-by: Minas Harutyunyan <hminas@...opsys.com>

> ---
> 
>   drivers/usb/dwc2/params.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index db97bb16ecc4..93380f7c32b4 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -110,7 +110,6 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg)
>   	p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI;
>   	p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 <<
>   		GAHBCFG_HBSTLEN_SHIFT;
> -	p->uframe_sched = false;
>   }
>   
>   static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg)
>