linux-kernel - Re: [REPOST PATCH 4/4] usb: dwc2: Turn on uframe_sched on "stm32f4x9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <410670D7E743164D87FA6160E7907A56013A5CBE67@am04wembxa.internal.synopsys.com>
Date:   Fri, 27 Jul 2018 11:11:15 +0000
From:   Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>
To:     Douglas Anderson <dianders@...omium.org>,
        "balbi@...nel.org" <balbi@...nel.org>,
        "Minas.Harutyunyan@...opsys.com" <Minas.Harutyunyan@...opsys.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "stefan.wahren@...e.com" <stefan.wahren@...e.com>,
        "grigor.tovmasyan@...opsys.com" <grigor.tovmasyan@...opsys.com>,
        "Bruno Herrera" <bruherrera@...il.com>,
        Zhangfei Gao <zhangfei.gao@...aro.org>,
        "john.stultz@...aro.org" <john.stultz@...aro.org>,
        Stephen Warren <swarren@...dotorg.org>,
        Jerome Brunet <jbrunet@...libre.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [REPOST PATCH 4/4] usb: dwc2: Turn on uframe_sched on
 "stm32f4x9_fsotg" platforms

On 7/27/2018 12:08 AM, Douglas Anderson wrote:
> There's no reason to have the uframe scheduler off on dwc2.  Running
> with uframe_sched = False is equivalent to saying "I don't want to run
> the correct code, I want to run the old and incorrect code".
> 
> The uframe scheduler has been off on stm32f4x9_fsotg since commit
> e35b135055e2 ("usb: dwc2: Add support for STM32F429/439/469 USB OTG
> HS/FS in FS mode (internal PHY)").  That commit is pretty recent, so
> it's unclear to me why the uframe scheduler was left off.  Hopefully
> it's because someone copied it from other parameters and didn't think
> to try it?
> 
> Presumably if everyone is good w/ the uframe_sched turned back on we
> can kill all the old and crufty non-uframe sched code.
> 
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

Reviewed-by: Minas Harutyunyan <hminas@...opsys.com>

> ---
> 
>   drivers/usb/dwc2/params.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index 93380f7c32b4..7be35bcde713 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -131,7 +131,6 @@ static void dwc2_set_stm32f4x9_fsotg_params(struct dwc2_hsotg *hsotg)
>   	p->max_packet_count = 256;
>   	p->phy_type = DWC2_PHY_TYPE_PARAM_FS;
>   	p->i2c_enable = false;
> -	p->uframe_sched = false;
>   	p->activate_stm_fs_transceiver = true;
>   }
>   
>