linux-kernel - Re: [PATCH 06/10] staging: gasket: sysfs: convert to standard logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAW3YpY2rD6adA8zcHxR6Ty+nkK=Hyj-DkntkdsbFfWg71PzHQ@mail.gmail.com>
Date:   Fri, 27 Jul 2018 10:00:37 -0700
From:   Todd Poynor <toddpoynor@...gle.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     "toddpoynor@...il.com" <toddpoynor@...il.com>,
        Rob Springer <rspringer@...gle.com>,
        John Joseph <jnjoseph@...gle.com>, benchan@...omium.org,
        devel@...verdev.osuosl.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 06/10] staging: gasket: sysfs: convert to standard logging

On Fri, Jul 27, 2018 at 8:07 AM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Thu, Jul 26, 2018 at 08:07:33PM -0700, Todd Poynor wrote:
> > From: Todd Poynor <toddpoynor@...gle.com>
> >
> > Drop gasket logging calls in favor of standard logging.
> >
> > Signed-off-by: Todd Poynor <toddpoynor@...gle.com>
> > ---
> >  drivers/staging/gasket/gasket_sysfs.c | 73 +++++++++++++--------------
> >  1 file changed, 35 insertions(+), 38 deletions(-)
> >
> > diff --git a/drivers/staging/gasket/gasket_sysfs.c b/drivers/staging/gasket/gasket_sysfs.c
> > index 1c5f7502e0d5e..418b81797e638 100644
> > --- a/drivers/staging/gasket/gasket_sysfs.c
> > +++ b/drivers/staging/gasket/gasket_sysfs.c
> > @@ -3,7 +3,9 @@
> >  #include "gasket_sysfs.h"
> >
> >  #include "gasket_core.h"
> > -#include "gasket_logging.h"
> > +
> > +#include <linux/device.h>
> > +#include <linux/printk.h>
> >
> >  /*
> >   * Pair of kernel device and user-specified pointer. Used in lookups in sysfs
> > @@ -66,7 +68,7 @@ static struct gasket_sysfs_mapping *get_mapping(struct device *device)
> >       int i;
> >
> >       if (!device) {
> > -             gasket_nodev_error("Received NULL device!");
> > +             pr_debug("%s: Received NULL device\n", __func__);
>
> I know you are just trying to clean up the logging mess, but this type
> of check isn't even needed, as it's impossible.

Ah, yeah, I noticed it when I was converting, I'll put this on my list
to clean up in next round, thanks.

>
> thanks,
>
> greg k-h