linux-kernel - Re: [PATCH v4 1/1] Staging: octeon-usb: Using defined error codes and applying coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180729202108.GB14390@darkstar.musicnaut.iki.fi>
Date:   Sun, 29 Jul 2018 23:21:09 +0300
From:   Aaro Koskinen <aaro.koskinen@....fi>
To:     Georgios Tsotsos <tsotsos@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        James Hogan <jhogan@...nel.org>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/1] Staging: octeon-usb: Using defined error codes
 and applying coding style

Hi,

On Sun, Jul 29, 2018 at 05:33:38PM +0300, Georgios Tsotsos wrote:
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 3f44ac260eff..edf87d1b3609 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2590,6 +2590,7 @@ static void cvmx_usb_transfer_isoc(struct octeon_hcd *usb,
>  		}
>  	} else {
>  		pipe->next_tx_frame += pipe->interval;
> +
>  		cvmx_usb_complete(usb, pipe, transaction, CVMX_USB_STATUS_OK);

Unrelated whitespace change...

>  	}
>  }
> @@ -2624,16 +2625,16 @@ static int cvmx_usb_dma_halt(u32 hcchar_chena, u32 hcint_xfercompl,
>  		cvmx_usb_write_csr32(usb,
>  				     CVMX_USBCX_HCCHARX(channel, usb->index),
>  				     usbc_hcchar.u32);
> -		return -1;
> +		return -EINVAL;
>  	} else if (hcint_xfercompl) {
>  		/*
>  		 * Successful IN/OUT with transfer complete.
>  		 * Channel halt isn't needed.
>  		 */
>  	} else {
> -		dev_err(dev, "USB%d: Channel %d interrupt without halt\n",
> +		dev_	err(dev, "USB%d: Channel %d interrupt without halt\n",
>  			usb->index, channel);

...also here. Does this even compile?

> -		return -1;
> +		return -EINVAL;
>  	}
>  
>  	return 0;
> -- 
> 2.16.4

A.