linux-kernel - Re: [PATCH 3/4 v3] arc: fix data type errors in platform headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180729202230.GR7157@mtr-leonro.mtl.com>
Date:   Sun, 29 Jul 2018 23:22:30 +0300
From:   Leon Romanovsky <leonro@...lanox.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     rd_dunlab <rd.dunlab@...il.com>,
        lkml <linux-kernel@...r.kernel.org>,
        Vineet Gupta <vgupta@...opsys.com>,
        linux-snps-arc@...ts.infradead.org,
        Elad Kanfi <eladkan@...lanox.com>,
        Ofer Levi <oferle@...lanox.com>
Subject: Re: [PATCH 3/4 v3] arc: fix data type errors in platform headers

On Sun, Jul 29, 2018 at 11:10:51AM -0700, Randy Dunlap wrote:
> On 07/29/2018 12:01 AM, Leon Romanovsky wrote:
> > On Thu, Jul 26, 2018 at 08:16:35PM -0700, rd_dunlab wrote:
> >> From: Randy Dunlap <rdunlap@...radead.org>
> >>
> >> Add <asm-generic/types.h> to fix build errors.
> >> Both ctop.h and <soc/nps/common.h> use u32 types and cause many
> >> errors.
> >>
> >> Examples:
> >> ../include/soc/nps/common.h:71:4: error: unknown type name 'u32'
> >>     u32 __reserved:20, cluster:4, core:4, thread:4;
> >> ../include/soc/nps/common.h:76:3: error: unknown type name 'u32'
> >>    u32 value;
> >> ../include/soc/nps/common.h:124:4: error: unknown type name 'u32'
> >>     u32 base:8, cl_x:4, cl_y:4,
> >> ../include/soc/nps/common.h:127:3: error: unknown type name 'u32'
> >>    u32 value;
> >>
> >> ../arch/arc/plat-eznps/include/plat/ctop.h:83:4: error: unknown type name 'u32'
> >>     u32 gen:1, gdis:1, clk_gate_dis:1, asb:1,
> >> ../arch/arc/plat-eznps/include/plat/ctop.h:86:3: error: unknown type name 'u32'
> >>    u32 value;
> >> ../arch/arc/plat-eznps/include/plat/ctop.h:93:4: error: unknown type name 'u32'
> >>     u32 csa:22, dmsid:6, __reserved:3, cs:1;
> >> ../arch/arc/plat-eznps/include/plat/ctop.h:95:3: error: unknown type name 'u32'
> >>    u32 value;
> >>
> >> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> >> Cc: Vineet Gupta <vgupta@...opsys.com>
> >> Cc: linux-snps-arc@...ts.infradead.org
> >> Cc: Elad Kanfi <eladkan@...lanox.com>
> >> Cc: Leon Romanovsky <leonro@...lanox.com>
> >> Cc: Ofer Levi <oferle@...lanox.com>
> >> ---
> >> v2: no change
> >>
> >>  arch/arc/plat-eznps/include/plat/ctop.h |    1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> --- linux-next-20180723.orig/arch/arc/plat-eznps/include/plat/ctop.h
> >> +++ linux-next-20180723/arch/arc/plat-eznps/include/plat/ctop.h
> >> @@ -21,6 +21,7 @@
> >>  #error "Incorrect ctop.h include"
> >>  #endif
> >>
> >> +#include <asm-generic/types.h>
> >
> > I'm not familiar with arch/* code, so maybe my question will sound
> > naive., but why "asm-generic/types.h" and not "linux/types.h"?
>
> Nope, good question.  That works and should be preferred.
>
> Please use the new patch below.
>
> --
>
> From: Randy Dunlap <rdunlap@...radead.org>
>
> Add <linux/types.h> to fix build errors.
> Both ctop.h and <soc/nps/common.h> use u32 types and cause many
> errors.
>
> Examples:
> ../include/soc/nps/common.h:71:4: error: unknown type name 'u32'
>     u32 __reserved:20, cluster:4, core:4, thread:4;
> ../include/soc/nps/common.h:76:3: error: unknown type name 'u32'
>    u32 value;
> ../include/soc/nps/common.h:124:4: error: unknown type name 'u32'
>     u32 base:8, cl_x:4, cl_y:4,
> ../include/soc/nps/common.h:127:3: error: unknown type name 'u32'
>    u32 value;
>
> ../arch/arc/plat-eznps/include/plat/ctop.h:83:4: error: unknown type name 'u32'
>     u32 gen:1, gdis:1, clk_gate_dis:1, asb:1,
> ../arch/arc/plat-eznps/include/plat/ctop.h:86:3: error: unknown type name 'u32'
>    u32 value;
> ../arch/arc/plat-eznps/include/plat/ctop.h:93:4: error: unknown type name 'u32'
>     u32 csa:22, dmsid:6, __reserved:3, cs:1;
> ../arch/arc/plat-eznps/include/plat/ctop.h:95:3: error: unknown type name 'u32'
>    u32 value;
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Vineet Gupta <vgupta@...opsys.com>
> Cc: linux-snps-arc@...ts.infradead.org
> Cc: Elad Kanfi <eladkan@...lanox.com>
> Cc: Leon Romanovsky <leonro@...lanox.com>
> Cc: Ofer Levi <oferle@...lanox.com>
> ---
> v2: no change
> v3: use <linux/types.h> instead of <asm-generic/types.h>
>
>  arch/arc/plat-eznps/include/plat/ctop.h |    1 +
>  1 file changed, 1 insertion(+)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...lanox.com>