linux-kernel - Re: [PATCH v2 3/7] staging: rtl8188eu: remove unused rtw_handle_tkip_mic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ab9ce0f-4b2b-912b-04af-736ee9f23d4e@gmail.com>
Date:   Mon, 30 Jul 2018 11:27:43 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/7] staging: rtl8188eu: remove unused
 rtw_handle_tkip_mic_err()

On 07/30/18 11:02, Greg KH wrote:
> On Sun, Jul 29, 2018 at 08:54:43PM +0200, Michael Straube wrote:
>> The function rtw_handle_tkip_mic_err() is never used, so remove it.
>> Discovered by cppcheck.
> 
> That's a bad tool then, as this is used, and the build breaks when this
> patch is applied :(
> 
> I've dropped it now.
> 
> thanks,
> 
> greg k-h
> 

Hm, that's weired, I also checked with:

git grep -n rtw_handle_tkip_mic_err drivers/staging/rtl8188eu/

There were/are no uses and the driver builds and works fine here.
I don't see what I may have missed here. :(

Regards,
Michael