linux-kernel - Re: [PATCH] sh: dwarf: prefer _THIS_IP_ to current_text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOd=DnrfVcuO8Pg=FBrub1M4A8LzarZbtv6m=JO_r6Ea6aQ@mail.gmail.com>
Date:   Wed, 1 Aug 2018 11:50:06 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Yoshinori Sato <ysato@...rs.sourceforge.jp>, dalias@...c.org
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-sh@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sh: dwarf: prefer _THIS_IP_ to current_text_addr

On Wed, Aug 1, 2018 at 11:29 AM Nick Desaulniers
<ndesaulniers@...gle.com> wrote:
>
> As part of the effort to reduce the code duplication between _THIS_IP_
> and current_text_addr(), let's consolidate callers of
> current_text_addr() to use _THIS_IP_.
>
> Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
> ---
>  arch/sh/kernel/dwarf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sh/kernel/dwarf.c b/arch/sh/kernel/dwarf.c
> index 1a2526676a87..bb511e2d9d68 100644
> --- a/arch/sh/kernel/dwarf.c
> +++ b/arch/sh/kernel/dwarf.c
> @@ -599,7 +599,7 @@ struct dwarf_frame *dwarf_unwind_stack(unsigned long pc,
>          * time this function makes its first function call.
>          */
>         if (!pc || !prev)
> -               pc = (unsigned long)current_text_addr();
> +               pc = _THIS_IP_;
>
>  #ifdef CONFIG_FUNCTION_GRAPH_TRACER
>         /*
> --
> 2.18.0.597.ga71716f1ad-goog
>

Sorry, there's another call site in the arch/sh/ tree
(arch/sh/include/asm/kexec.h#64).  Let me fix both and send as a
single patch in v2.
-- 
Thanks,
~Nick Desaulniers