linux-kernel - Re: [PATCH RESEND 1/2] staging: erofs: add the missing break in z_erofs_map_blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69349ab1-e38f-c755-e966-6bf787ccc896@huawei.com>
Date:   Wed, 1 Aug 2018 20:08:46 +0800
From:   Gao Xiang <gaoxiang25@...wei.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <devel@...verdev.osuosl.org>, <yuchao0@...wei.com>,
        <linux-erofs@...ts.ozlabs.org>, <hsiangkao@....com>,
        <linux-kernel@...r.kernel.org>, <weidu.du@...wei.com>,
        <miaoxie@...wei.com>, <chao@...nel.org>
Subject: Re: [PATCH RESEND 1/2] staging: erofs: add the missing break in
 z_erofs_map_blocks_iter

Hi Dan,

On 2018/8/1 19:36, Dan Carpenter wrote:
> On Wed, Aug 01, 2018 at 05:36:54PM +0800, Gao Xiang wrote:
>> This patch adds a missing break after adding the default case.
>>
>> Reviewed-by: Chao Yu <yuchao0@...wei.com>
>> Signed-off-by: Gao Xiang <gaoxiang25@...wei.com>
>> ---
>> As pointed out by Dan Carpenter:
>>  - fix the wrong place of fallthrough comments
> Thanks.  Looks good.  Next time use [PATCH v2] instead of RESEND.  The
> word RESEND basically means you are resending a patch exactly the same
> as it was before.  You would only need to do that if we accidentally
> deleted your first patch or whatever...
> 
> regards,
> dan carpenter
> 
> 
OK, it should not be titled RESEND, and I will take care the next time.
Thanks for taking the time to review :)

Thanks,
Gao Xiang