linux-kernel - [tip:core/debugobjects] debugobjects: Remove redundant NULL pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-3ff4f80a74fd38398ae1bd8a458ba9c51aa0dd44@git.kernel.org>
Date:   Thu, 2 Aug 2018 04:57:55 -0700
From:   tip-bot for Zhong Jiang <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     yang.shi@...ux.alibaba.com, zhongjiang@...wei.com, arnd@...db.de,
        mingo@...nel.org, longman@...hat.com, hpa@...or.com,
        tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: [tip:core/debugobjects] debugobjects: Remove redundant NULL pointer
 check

Commit-ID:  3ff4f80a74fd38398ae1bd8a458ba9c51aa0dd44
Gitweb:     https://git.kernel.org/tip/3ff4f80a74fd38398ae1bd8a458ba9c51aa0dd44
Author:     Zhong Jiang <zhongjiang@...wei.com>
AuthorDate: Wed, 1 Aug 2018 00:24:58 +0800
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Thu, 2 Aug 2018 13:53:04 +0200

debugobjects: Remove redundant NULL pointer check

kmem_cache_destroy() has a built in NULL pointer check, so the one at the
call can be removed.

Signed-off-by: Zhong Jiang <zhongjiang@...wei.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: <longman@...hat.com>
Cc: <arnd@...db.de>
Cc: <yang.shi@...ux.alibaba.com>
Link: https://lkml.kernel.org/r/1533054298-35824-1-git-send-email-zhongjiang@huawei.com

---
 lib/debugobjects.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/debugobjects.c b/lib/debugobjects.c
index 24c1df0d7466..70935ed91125 100644
--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -1188,8 +1188,7 @@ void __init debug_objects_mem_init(void)
 
 	if (!obj_cache || debug_objects_replace_static_objects()) {
 		debug_objects_enabled = 0;
-		if (obj_cache)
-			kmem_cache_destroy(obj_cache);
+		kmem_cache_destroy(obj_cache);
 		pr_warn("out of memory.\n");
 	} else
 		debug_objects_selftest();