linux-kernel - Re: [PATCH v2] fs/nfsd: Delete invalid assignment statements in nfsd4_decode_exchange

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180802131951.GA30706@fieldses.org>
Date:   Thu, 2 Aug 2018 09:19:51 -0400
From:   "J. Bruce Fields" <bfields@...ldses.org>
To:     Nixiaoming <nixiaoming@...wei.com>
Cc:     "jlayton@...nel.org" <jlayton@...nel.org>,
        "chuck.lever@...cle.com" <chuck.lever@...cle.com>,
        "trondmy@...merspace.com" <trondmy@...merspace.com>,
        "andros@...app.com" <andros@...app.com>,
        "linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] fs/nfsd: Delete invalid assignment statements in
 nfsd4_decode_exchange_id

On Thu, Aug 02, 2018 at 01:00:26PM +0000, Nixiaoming wrote:
> On Wednesday, August 01, 2018 11:18 PM ,  J. Bruce Fields  wrote: 
> >On Mon, Jul 23, 2018 at 09:57:11AM +0800, nixiaoming wrote:
> >> READ_BUF(8);
> >> dummy = be32_to_cpup(p++);
> >> dummy = be32_to_cpup(p++);
> >> ...
> >> READ_BUF(4);
> >> dummy = be32_to_cpup(p++);
> >> 
> >> Assigning value to "dummy" here, but that stored value
> >> is overwritten before it can be used.
> >> At the same time READ_BUF() will re-update the pointer p.
> >> 
> >> delete invalid assignment statements
> >
> >Thanks, applying with a minor comment tweak to clarify that we're
> >intentionally not reading these:
> >
> >-		/* ssp_window and ssp_num_gss_handles */
> >+		/* ignore ssp_window and ssp_num_gss_handles: */
> > 		READ_BUF(8);
> > 		break;
> >
> >--b.
> >
> 
> Thanks for your advice
> I will update the patch as soon as possible according to your advice.

I've taken care of it, no need to update.

--b.