linux-kernel - Re: [PATCH v3 0/6] KVM: nVMX: Enlightened VMCS for Hyper-V on KVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871sbgaonv.fsf@vitty.brq.redhat.com>
Date:   Thu, 02 Aug 2018 15:22:44 +0200
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     kvm@...r.kernel.org,
        Radim Krčmář <rkrcmar@...hat.com>,
        Roman Kagan <rkagan@...tuozzo.com>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "Michael Kelley \(EOSG\)" <Michael.H.Kelley@...rosoft.com>,
        Mohammed Gamal <mmorsy@...hat.com>,
        Cathy Avery <cavery@...hat.com>, linux-kernel@...r.kernel.org,
        Jim Mattson <jmattson@...gle.com>,
        Liran Alon <liran.alon@...cle.com>
Subject: Re: [PATCH v3 0/6] KVM: nVMX: Enlightened VMCS for Hyper-V on KVM

Paolo Bonzini <pbonzini@...hat.com> writes:

> On 25/07/2018 18:30, Vitaly Kuznetsov wrote:
>> Changes since v2:
>> - Rebase to the current kvm/queue.
>> - Simplify clean fields check in prepare_vmcs02{,_full} and
>>   copy_enlightened_to_vmcs12() by resetting the clean fields mask in
>>   nested_vmx_handle_enlightened_vmptrld() when we switch from one L2 guest
>>   to another [Paolo Bonzini]
>> - Cope with the newly introduced vmx_get_nested_state() by returning
>>   -ENOTSUPP when eVMCS is in use. We'll do proper nested state save/restore
>>   later.
>
> Looks good, but we have to do something about live migration.

Sure,

I don't actually see any fundumental problems when eVMCS is in use,
however, I'd like to enable migration when we know that it works so I
was going to wait for your nested virtualization state migration series
to land and gain Qemu support before starting to experiment. "One bite
at a time".

> Perhaps you can write a testcase analogous to the new state_test, that
> tests eVMCS in general before we have support in QEMU.

I'll take a look, thanks for the pointer!

-- 
  Vitaly