linux-kernel - Re: [PATCH] fs/binfmt_elf: remove the same condition check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180802030442.GW30522@ZenIV.linux.org.uk>
Date:   Thu, 2 Aug 2018 04:04:43 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/binfmt_elf: remove the same condition check

On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote:
> dump_align is used to double check in a expression. It is redundant.
> so just remove one of them.

<mode eliza>
What makes you think that it is redundant?
</mode>

> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  fs/binfmt_elf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
> index efae2fb..b6c5b02 100644
> --- a/fs/binfmt_elf.c
> +++ b/fs/binfmt_elf.c
> @@ -1439,7 +1439,7 @@ static int writenote(struct memelfnote *men, struct coredump_params *cprm)
>  
>  	return dump_emit(cprm, &en, sizeof(en)) &&
>  	    dump_emit(cprm, men->name, en.n_namesz) && dump_align(cprm, 4) &&
> -	    dump_emit(cprm, men->data, men->datasz) && dump_align(cprm, 4);
> +	    dump_emit(cprm, men->data, men->datasz);
>  }
>  
>  static void fill_elf_header(struct elfhdr *elf, int segs,
> -- 
> 1.7.12.4
>