linux-kernel - Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180802030522.GX30522@ZenIV.linux.org.uk>
Date:   Thu, 2 Aug 2018 04:05:22 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in
 writenote

On Thu, Aug 02, 2018 at 10:04:34AM +0800, zhong jiang wrote:
> It is unncessary to use double test for a expression. so just
> remove one of them.

... except when something in that expression might have side effects,
that is.