linux-kernel - Re: [PATCH] firmware: make sure builtin firmware is page alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1533285744.20683.67.camel@intel.com>
Date:   Fri, 3 Aug 2018 08:42:25 +0000
From:   "Zhang, Ning A" <ning.a.zhang@...el.com>
To:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "pombredanne@...b.com" <pombredanne@...b.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Li, Ting" <ting.li@...el.com>,
        "yamada.masahiro@...ionext.com" <yamada.masahiro@...ionext.com>,
        "kstewart@...uxfoundation.org" <kstewart@...uxfoundation.org>,
        "markus@...ppelsdorf.de" <markus@...ppelsdorf.de>
Subject: Re: [PATCH] firmware: make sure builtin firmware is page alignment

在 2018-08-03五的 07:39 +0200，Greg KH写道：
> On Fri, Aug 03, 2018 at 09:45:21AM +0800, Zhang Ning wrote:
> > when firmware is in filesystem, request_firmware will load it,
> > and copy it to vmalloc memory, that is page align memory.
> > 
> > but when firmware is builtin, it is 8 bytes or 4 bytes alignment.
> > 
> > make sure builtin firmware is page algnment, that can simplify
> > algorithm
> > to handle firmware.
> 
> How is it simplified?  I don't see any such change like that here :(
> 
Thank you for review this patch.

When driver handles its firmware based on  page, like below:

	struct page *p;
	p = vmalloc_to_page(fw->data);  // for filesystem firmware
	p = virt_to_page(fw->data); // for builtin firmware

but if builtin firmware is not page alignment, page pointer for builtin
firmware is wrong, it contains memory not belong to firmware. drivers
has to use additional code to handle this. 

if builtin firmware is also page alignment, no need additional code to
handle builtin firmware. simplified.

BR.
Ning.