linux-kernel - Re: [PATCH] aoe: mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 2 Aug 2018 20:26:29 -0400
From:   Ed Cashin <ecashin@...erose.net>
To:     gustavo@...eddedor.com
Cc:     "Ed L. Cashin" <ed.cashin@....org>, axboe@...nel.dk,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] aoe: mark expected switch fall-through

On Wed, Aug 1, 2018 at 6:30 PM Gustavo A. R. Silva <gustavo@...eddedor.com>
wrote:

> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.


OK, thanks.


>
> diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
> index 096882e..136dc50 100644
> --- a/drivers/block/aoe/aoecmd.c
> +++ b/drivers/block/aoe/aoecmd.c
> @@ -1137,6 +1137,7 @@ noskb:            if (buf)
>                         break;
>                 }
>                 bvcpy(skb, f->buf->bio, f->iter, n);
> +               /* fall through */
>         case ATA_CMD_PIO_WRITE:
>         case ATA_CMD_PIO_WRITE_EXT:
>                 spin_lock_irq(&d->lock);
> --
> 2.7.4
>
>

-- 
  Ed Cashin <ecashin@...erose.net>

Content of type "text/html" skipped