linux-kernel - Re: [PATCH] RISC-V: Add preprocessor directives for boot_sec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 Aug 2018 08:27:57 +0800
From:   Zong Li <zongbox@...il.com>
To:     atish.patra@....com
Cc:     Zong Li <zong@...estech.com>, Palmer Dabbelt <palmer@...ive.com>,
        aou@...s.berkeley.edu, hch@...radead.org,
        linux-riscv@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        greentime@...estech.com
Subject: Re: [PATCH] RISC-V: Add preprocessor directives for boot_sec_cpu

Atish Patra <atish.patra@....com> 於 2018年8月3日 週五 上午2:14寫道：
>
> On 8/2/18 8:23 AM, Zong Li wrote:
> > The boot_sec_cpu is for hutplug CPU on SMP system. It should
> > be conditional compiling. Otherwise, it causes undefined reference
> > to `smp_callin' when compiling uniprocessor kernel.
> >
> > Signed-off-by: Zong Li <zong@...estech.com>
> > ---
> >   arch/riscv/kernel/head.S | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/riscv/kernel/head.S b/arch/riscv/kernel/head.S
> > index 11066d5..9b6f601 100644
> > --- a/arch/riscv/kernel/head.S
> > +++ b/arch/riscv/kernel/head.S
> > @@ -154,6 +154,7 @@ END(_start)
> >   .section .text
> >   .global boot_sec_cpu
> >
> > +#ifdef CONFIG_HOTPLUG_CPU
> >   boot_sec_cpu:
> >       /* clear all pending flags */
> >       csrw sip, zero
> > @@ -162,6 +163,7 @@ boot_sec_cpu:
> >       fence
> >
> >       tail smp_callin
> > +#endif
> >
> >   __PAGE_ALIGNED_BSS
> >       /* Empty zero page */
> >
>
> Thanks for the fix. If you don't mind, I would like to merge it on top
> of my cpu hotplug patch and resubmit together to avoid confusion.
>
OK, just take it:)