linux-kernel - Re: [PATCH 0/2] gpio: mvebu: Add support for multiple PWM lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sh3vbxlf.fsf@bootlin.com>
Date:   Fri, 03 Aug 2018 11:36:44 +0200
From:   Gregory CLEMENT <gregory.clement@...tlin.com>
To:     aditya@...ol.io, Linus Walleij <linus.walleij@...aro.org>
Cc:     Gregory CLEMENT <gregory.clement@...e-electrons.com>,
        Ralph Sennhauser <ralph.sennhauser@...il.com>,
        Richard Genoud <richard.genoud@...il.com>,
        "open list\:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        gauthier@...ol.io, alban.browaeys@...il.com,
        "thierry.reding\@gmail.com" <thierry.reding@...il.com>,
        linux-pwm@...r.kernel.org,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] gpio: mvebu: Add support for multiple PWM lines

Hi Linus and Adita
 
 On dim., juil. 29 2018, Linus Walleij <linus.walleij@...aro.org> wrote:

> Hoping for some review from Gergory, Ralph or Richard who all seem
> to use this driver!

Would it be possible to resend the series adding me in CC?  I would
like to comment the patches, but unfortunately it seems that I was in
none of the mailing list where the series had been sent.

I found the patches on patchwork, and started to have a look on it for
example, in the patch "gpio: mvebu: Add support for multiple PWM lines
per GPIO chip", I wonder why the id is stored as it was not used at all.

Having the patch inlined in an email would male the review easier.

Thanks,

Gregory

>
> Yours,
> Linus Walleij
>
> On Fri, Jul 20, 2018 at 9:24 PM Aditya Prayoga <aditya@...ol.io> wrote:
>>
>> Hi everyone,
>>
>> Helios4, an Armada 388 based NAS SBC, provides 2 (4-pins) fan connectors.
>> The PWM pins on both connector are connected to GPIO on bank 1. Current gpio-
>> mvebu does not allow more than one PWM on the same bank.
>>
>> Aditya
>>
>> ---
>>
>> Aditya Prayoga (2):
>>   gpio: mvebu: Add support for multiple PWM lines per GPIO chip
>>   gpio: mvebu: Allow to use non-default PWM counter
>>
>>  drivers/gpio/gpio-mvebu.c | 111 ++++++++++++++++++++++++++++++++++++++--------
>>  1 file changed, 92 insertions(+), 19 deletions(-)
>>
>> --
>> 2.7.4
>>

-- 
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com