linux-kernel - Re: [PATCH] ACPI: nfit: return -ENODEV if fail to find NFIT at startup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1533316299.8557.71.camel@intel.com>
Date:   Fri, 3 Aug 2018 17:11:41 +0000
From:   "Verma, Vishal L" <vishal.l.verma@...el.com>
To:     "Williams, Dan J" <dan.j.williams@...el.com>,
        "ross.zwisler@...ux.intel.com" <ross.zwisler@...ux.intel.com>,
        "oceanhehy@...il.com" <oceanhehy@...il.com>,
        "Jiang, Dave" <dave.jiang@...el.com>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "hehy1@...ovo.com" <hehy1@...ovo.com>
Subject: Re: [PATCH] ACPI: nfit: return -ENODEV if fail to find NFIT at
 startup


On Fri, 2018-08-03 at 05:39 -0400, Ocean He wrote:
> From: Ocean He <hehy1@...ovo.com>
> 
> In the beginning of acpi_nfit_add, if fail to find NFIT table then
> should
> return -ENODEV, instead of 0.
> 
> Signed-off-by: Ocean He <hehy1@...ovo.com>
> ---
>  drivers/acpi/nfit/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 7c47900..1790d7c 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -3355,7 +3355,7 @@ static int acpi_nfit_add(struct acpi_device
> *adev)
>  	if (ACPI_FAILURE(status)) {
>  		/* This is ok, we could have an nvdimm hotplugged
> later */
>  		dev_dbg(dev, "failed to find NFIT at startup\n");
> -		return 0;
> +		return -ENODEV;

Hm, the comment directly above this says this is ok..
Has this caused any problems in practice?

>  	}
>  
>  	rc = devm_add_action_or_reset(dev, acpi_nfit_put_table,
> tbl);