linux-kernel - Re: [PATCH 1/4] soc: amlogic: add meson-canvas driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHStOZ5W+jJRox3=Nnem+Z1zopFOUenpmT-QkUzd5hrmKXfX5A@mail.gmail.com>
Date:   Fri, 3 Aug 2018 23:47:51 +0200
From:   Maxime Jourdan <maxi.jourdan@...adoo.fr>
To:     Yixun Lan <yixun.lan@...il.com>
Cc:     Maxime Jourdan <maxi.jourdan@...adoo.fr>,
        Kevin Hilman <khilman@...libre.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic <linux-amlogic@...ts.infradead.org>
Subject: Re: [PATCH 1/4] soc: amlogic: add meson-canvas driver

Hi Yixun, thanks for the review

2018-08-03 16:14 GMT+02:00 Yixun Lan <yixun.lan@...il.com>:
>> +config MESON_CANVAS
>> +       bool "Amlogic Meson Canvas driver"
> shouldn't this a 'tristate'? since you'd make the driver a kernel module..

Yep it should!

I well noted your other feedback and v2 will have fixes for them :) .