linux-kernel - Re: [PATCH] kernel/kthread: Make function __kthread_queue_delayed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5B66FCF9.8000903@huawei.com>
Date:   Sun, 5 Aug 2018 21:34:49 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     Steven Rostedt <rostedt@...dmis.org>
CC:     <mingo@...hat.com>, <peterz@...radead.org>, <tglx@...utronix.de>,
        <linux-kernel@...r.kernel.org>, <trivial@...nel.org>
Subject: Re: [PATCH] kernel/kthread:  Make function __kthread_queue_delayed_work
 static

On 2018/8/3 21:21, Steven Rostedt wrote:
> On Fri, 3 Aug 2018 20:40:02 +0800
> zhong jiang <zhongjiang@...wei.com> wrote:
>
>> Fix the following warning.
>>
>> kernel/kthread.c:859:6: warning: symbol '__kthread_queue_delayed_work' was not declared. Should it be static?
>
> This should go via the trivial tree.
>
>> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
>> ---
>>  kernel/kthread.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/kthread.c b/kernel/kthread.c
>> index 087d18d..3c661a0 100644
>> --- a/kernel/kthread.c
>> +++ b/kernel/kthread.c
>> @@ -856,7 +856,7 @@ void kthread_delayed_work_timer_fn(struct timer_list *t)
>>  }
>>  EXPORT_SYMBOL(kthread_delayed_work_timer_fn);
>>  
>> -void __kthread_queue_delayed_work(struct kthread_worker *worker,
>> +static void __kthread_queue_delayed_work(struct kthread_worker *worker,
>>  				  struct kthread_delayed_work *dwork,
>>  				  unsigned long delay)
> Although, one could say you should align the parameters too, but that's
> not a big deal. Anyway...
>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
  Thanks , I will notice for next time.
> -- Steve
>
>>  {
>
> .
>