linux-kernel - Re: [RFC PATCH 1/2] checkpatch: Correctly detect git commit references that span 3 lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <7a9ee916-bf83-1f84-1799-9e668d0b3712@au1.ibm.com>
Date:   Mon, 6 Aug 2018 18:37:37 +1000
From:   Andrew Donnellan <andrew.donnellan@....ibm.com>
To:     Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org,
        apw@...onical.com
Cc:     fbarrat@...ux.vnet.ibm.com
Subject: Re: [RFC PATCH 1/2] checkpatch: Correctly detect git commit
 references that span 3 lines

On 06/08/18 15:07, Joe Perches wrote:
> The multiple line block code can be difficult to read.

I 100% agree!

> My suggestion is to instead write a subroutine to get the
> commit description and compare that against the returned
> git commit description.

I'll try and do it up more neatly when I've got some spare time over the 
next few days and send a v2.

Thanks,
-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@....ibm.com  IBM Australia Limited