linux-kernel - Re: [RFC PATCH 1/2] checkpatch: Correctly detect git commit references that span 3 lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c99001394ca5cb13fefc56d5b854be1f4c7e0624.camel@perches.com>
Date:   Sun, 05 Aug 2018 22:07:38 -0700
From:   Joe Perches <joe@...ches.com>
To:     Andrew Donnellan <andrew.donnellan@....ibm.com>,
        linux-kernel@...r.kernel.org, apw@...onical.com
Cc:     fbarrat@...ux.vnet.ibm.com
Subject: Re: [RFC PATCH 1/2] checkpatch: Correctly detect git commit
 references that span 3 lines

On Mon, 2018-08-06 at 13:58 +1000, Andrew Donnellan wrote:
> If a patch contains a commit reference that happens to span 3 lines, e.g.:
> 
> ===
> With the optimizations for TLB invalidation from commit 0cef77c7798a
> ("powerpc/64s/radix: flush remote CPUs out of single-threaded
> mm_cpumask"), the scope of a TLBI (global vs. local) can now be
> influenced by the value of the 'copros' counter of the memory context.
> ===
> 
> checkpatch will return a GIT_COMMIT_ID error even though the reference
> actually follows the correct format.

The multiple line block code can be difficult to read.

My suggestion is to instead write a subroutine to get the
commit description and compare that against the returned
git commit description.