linux-kernel - Re: [PATCH] x86/irqflags: provide a declaration for native_save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+icZUXtw6FUu8TpTY0Bn3BaDkb1zKuzLtBMz7oHLjJ=+2ojxw@mail.gmail.com>
Date:   Mon, 6 Aug 2018 12:38:26 +0200
From:   Sedat Dilek <sedat.dilek@...il.com>
To:     David Laight <David.Laight@...lab.com>
Cc:     Nick Desaulniers <ndesaulniers@...gle.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
        "jgross@...e.com" <jgross@...e.com>,
        "kstewart@...uxfoundation.org" <kstewart@...uxfoundation.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "boris.ostrovsky@...cle.com" <boris.ostrovsky@...cle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jdelvare@...e.de" <jdelvare@...e.de>,
        "astrachan@...gle.com" <astrachan@...gle.com>,
        "mka@...omium.org" <mka@...omium.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "tstellar@...hat.com" <tstellar@...hat.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] x86/irqflags: provide a declaration for native_save_fl

On Mon, Aug 6, 2018 at 12:25 PM, David Laight <David.Laight@...lab.com> wrote:
> From: Nick Desaulniers
>> Sent: 03 August 2018 18:06
>> Fixes commit d0a8d9378d16 ("x86/paravirt: Make native_save_fl() extern
>> inline").
>>
>> It was reported that the above commit was causing users of gcc < 4.9 to
>> observe -Werror=missing-prototypes errors.
>>
>> Indeed, it seems that:
>> extern inline unsigned long native_save_fl(void) { return 0; }
>>
>> compiled with -Werror=missing-prototypes produces this warning in gcc <
>> 4.9, but not gcc >= 4.9.
>>
>> Cc: stable@...r.kernel.org # 4.17, 4.14, 4.9, 4.4
>> Reported-by: David Laight <david.laight@...lab.com>
>> Reported-by: Jean Delvare <jdelvare@...e.de>
>> Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
>
> You can add my:
>
> Tested-by: David Laight <david.laight@...ab.com>
>

Tested-by: Sedat Dilek <sedat.dilek@...il.com>

On top of Linux v4.18-rc8 with clang version 7.0.0-svn338205.

- sed@ -