linux-kernel - Re: [tip:x86/urgent] x86/irqflags: Provide a declaration for native_save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Aug 2018 14:33:41 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     hpa@...or.com, Thomas Gleixner <tglx@...utronix.de>,
        david.laight@...lab.com, LKML <linux-kernel@...r.kernel.org>,
        jdelvare@...e.de, Ingo Molnar <mingo@...nel.org>
Cc:     linux-tip-commits@...r.kernel.org, sedat.dilek@...il.com
Subject: Re: [tip:x86/urgent] x86/irqflags: Provide a declaration for native_save_fl

On Sun, Aug 5, 2018 at 1:33 PM tip-bot for Nick Desaulniers
<tipbot@...or.com> wrote:
>
> Commit-ID:  208cbb32558907f68b3b2a081ca2337ac3744794
> Gitweb:     https://git.kernel.org/tip/208cbb32558907f68b3b2a081ca2337ac3744794
> Author:     Nick Desaulniers <ndesaulniers@...gle.com>
> AuthorDate: Fri, 3 Aug 2018 10:05:50 -0700
> Committer:  Thomas Gleixner <tglx@...utronix.de>
> CommitDate: Sun, 5 Aug 2018 22:30:37 +0200
>
> x86/irqflags: Provide a declaration for native_save_fl
>
> It was reported that the commit d0a8d9378d16 is causing users of gcc < 4.9
> to observe -Werror=missing-prototypes errors.
>
> Indeed, it seems that:
> extern inline unsigned long native_save_fl(void) { return 0; }
>
> compiled with -Werror=missing-prototypes produces this warning in gcc <
> 4.9, but not gcc >= 4.9.
>
> Fixes: d0a8d9378d16 ("x86/paravirt: Make native_save_fl() extern inline").
> Reported-by: David Laight <david.laight@...lab.com>
> Reported-by: Jean Delvare <jdelvare@...e.de>
> Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: hpa@...or.com
> Cc: jgross@...e.com
> Cc: kstewart@...uxfoundation.org
> Cc: gregkh@...uxfoundation.org
> Cc: boris.ostrovsky@...cle.com
> Cc: astrachan@...gle.com
> Cc: mka@...omium.org
> Cc: arnd@...db.de
> Cc: tstellar@...hat.com
> Cc: sedat.dilek@...il.com
> Cc: David.Laight@...lab.com
> Cc: stable@...r.kernel.org

Not sure if this was going to be cleaned up in an automated way, but
looks like this commit message drops the comment to stable as to how
far back it should go:

# 4.17, 4.14, 4.9, 4.4

also, there were tested by's reported:

Tested-by: David Laight <david.laight@...ab.com>
Tested-by: Sedat Dilek <sedat.dilek@...il.com>

--
Thanks,
~Nick Desaulniers