linux-kernel - Re: [PATCH] s390x/mm: avoid taking the table lock in gmap_pmd_op

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <d3e543bc-d0ff-c8ef-f097-eeba2bde6971@linux.ibm.com>
Date:   Tue, 7 Aug 2018 09:26:07 +0200
From:   Janosch Frank <frankja@...ux.ibm.com>
To:     David Hildenbrand <david@...hat.com>, linux-kernel@...r.kernel.org
Cc:     linux-s390@...r.kernel.org,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Cornelia Huck <cohuck@...hat.com>,
        Christian Borntraeger <borntraeger@...ibm.com>
Subject: Re: [PATCH] s390x/mm: avoid taking the table lock in
 gmap_pmd_op_walk()

On 06.08.2018 17:54, David Hildenbrand wrote:
> Right now we temporarily take the page table lock in gmap_pmd_op_walk()
> even though we know we won't need it (if we can never have 1mb pages
> mapped into the gmap).
> 
> So let's special case this, so
> gmap_protect_range()/gmap_sync_dirty_log_pmd() will not take the lock in
> case huge pages are not allowed.

So, let's make this a special case

> 
> gmap_protect_range() is called quite frequently for managing shadow
> page tables in vSIE environments.
> 
> Signed-off-by: David Hildenbrand <david@...hat.com>

If you make the patch title more specific:
Reviewed-by: Janosch Frank <frankja@...ux.ibm.com>

I considered getting rid of the last unlock with the !large check, but
in theory somebody could run a VM with the HPAGE CAP and 4k pages which
would then result in havoc if we wouldn't also adapt gmap_pmd_op_end.

> ---
>  arch/s390/mm/gmap.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c
> index bb44990c8212..d4fa0a4514e0 100644
> --- a/arch/s390/mm/gmap.c
> +++ b/arch/s390/mm/gmap.c
> @@ -905,10 +905,16 @@ static inline pmd_t *gmap_pmd_op_walk(struct gmap *gmap, unsigned long gaddr)
>  	pmd_t *pmdp;
>  
>  	BUG_ON(gmap_is_shadow(gmap));
> -	spin_lock(&gmap->guest_table_lock);
>  	pmdp = (pmd_t *) gmap_table_walk(gmap, gaddr, 1);
> +	if (!pmdp)
> +		return NULL;
>  
> -	if (!pmdp || pmd_none(*pmdp)) {
> +	/* without huge pages, there is no need to take the table lock */
> +	if (!gmap->mm->context.allow_gmap_hpage_1m)
> +		return pmd_none(*pmdp) ? NULL : pmdp;
> +
> +	spin_lock(&gmap->guest_table_lock);
> +	if (pmd_none(*pmdp)) {
>  		spin_unlock(&gmap->guest_table_lock);
>  		return NULL;
>  	}
> 




Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)