linux-kernel - Re: [PATCH] s390x/mm: avoid taking the table lock in gmap_pmd_op

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85e72251-fa72-9a3f-e2b0-6bc7d9482908@redhat.com>
Date:   Tue, 7 Aug 2018 10:35:56 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Janosch Frank <frankja@...ux.ibm.com>, linux-kernel@...r.kernel.org
Cc:     linux-s390@...r.kernel.org,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Cornelia Huck <cohuck@...hat.com>,
        Christian Borntraeger <borntraeger@...ibm.com>
Subject: Re: [PATCH] s390x/mm: avoid taking the table lock in
 gmap_pmd_op_walk()

On 07.08.2018 09:26, Janosch Frank wrote:
> On 06.08.2018 17:54, David Hildenbrand wrote:
>> Right now we temporarily take the page table lock in gmap_pmd_op_walk()
>> even though we know we won't need it (if we can never have 1mb pages
>> mapped into the gmap).
>>
>> So let's special case this, so
>> gmap_protect_range()/gmap_sync_dirty_log_pmd() will not take the lock in
>> case huge pages are not allowed.
> 
> So, let's make this a special case
> 
>>
>> gmap_protect_range() is called quite frequently for managing shadow
>> page tables in vSIE environments.
>>
>> Signed-off-by: David Hildenbrand <david@...hat.com>
> 
> If you make the patch title more specific:
> Reviewed-by: Janosch Frank <frankja@...ux.ibm.com>


"s390/mm: optimize locking without huge pages in gmap_pmd_op_walk()"

Thanks!

-- 

Thanks,

David / dhildenb